largefile.lha utility/text - Comments

alfkil (93.160.247.156) @ 23 Dec 2012, 12:08.49

Sun, 23 Dec 2012 00:08:49 +0100

By: alfkil (93.160.247.156)

@samo 
The scrollbar thing you mention is not a bug. What the scrollbar does is it tells you which block you are currently in. If you have a blocksize of 4096 (the default), the block will most likely be larger than the window. The mousewheel will scroll inside the block, but will not change the block position (no new data is loaded). 
@xenic 
Thanks for testing, and yes you are right I should use DOS to convert paths. I will make an update after Christmas.

alfkil (93.160.247.156) @ 23 Dec 2012, 12:08.22

Sun, 23 Dec 2012 00:08:22 +0100

By: alfkil (93.160.247.156)

@samo 
The scrollbar thing you mention is not a bug. What the scrollbar does is it tells you which block you are currently in. If you have a blocksize of 4096 (the default), the block will most likely be larger than the window. The mousewheel will scroll inside the block, but will not change the block position (no new data is loaded). 
@xenic 
Thanks for testing, and yes you are right I should use DOS to convert paths. I will make an update after Christmas.

samo79 (93.144.66.179) @ 16 Dec 2012, 07:59.41

Sun, 16 Dec 2012 19:59:41 +0100

By: samo79 (93.144.66.179)

It seems that the scrollbar will not follow the "real" scroll, expecially if you use the mouse whell 
 
Also would be good to add a sort of drag&drop feature --> drop text file into the program to open it automatically :-)

xenic (71.58.155.85) @ 16 Dec 2012, 05:37.25

Sun, 16 Dec 2012 17:37:25 +0100

By: xenic (71.58.155.85)

v0.2: I am busy with my own projects and don't really have time for beta testing. However, I did D/L you new version and here is what I noticed: 
 
Your file loading still doesn't work in all cases but at least now it does 
not crash the program. If you select "parent" in the filerequester and then 
attempt to open a file, the program will fail to open the file. For example, 
I extracted LargeFile to RAM:, started the program, selected the "Open" 
button, selected "Parent" in the ASL requester, clicked on a file and 
selected "OK" in the ASL requester. LargeFile attempted to load a file 
that didn't exist ( //myfile.txt ). 
 
Just let AmigaDOS combine the path and file for you. It's more or less the 
standard method for combining the results of an ASL requester and will 
always work. 
 
Replace this: 
 
if(req->fr_Drawer[strlen(req->fr_Drawer)-1] == ':') 
sprintf(ret, "%s%s", req->fr_Drawer, req->fr_File); 
else 
sprintf (ret, "%s/%s", req->fr_Drawer, req->fr_File); 
 
with something like this: 
 
sprintf (ret, "%s", req->fr_Drawer); 
IDOS->AddPart(ret, req->fr_File, 1024); 
 
I didn't find any crashes.

alfkil (89.150.118.165) @ 14 Dec 2012, 11:55.07

Fri, 14 Dec 2012 23:55:07 +0100

By: alfkil (89.150.118.165)

@xenic 
Yes I know, and I fixed it already. I am just waiting for someone to do the final test before uploading, would you be interested? Find my email in the readme.

xenic (71.58.155.85) @ 14 Dec 2012, 09:00.41

Fri, 14 Dec 2012 21:00:41 +0100

By: xenic (71.58.155.85)

I would be surprised if it works well there if you select a different volume and directory to open the file from. I looked at the code and can tell you what is wrong. When the user selects a different location to open the file from, your code concatenates the pathname & filename incorrectly. This following line doesn't work properly: 
 
sprintf (ret, "%s/%s", req->fr_Drawer, req->fr_File); 
 
If req->fr_Drawer is "RAM:" and req->fr_File is "myfile" the above line of code concatenates it to "RAM:/myfile" which isn't right. Then you open the file with that bogus path and don't bother to check if the file was opened successfully; you just attemt to use a NULL filehandle. 
Overall the program needs more error checking but fixing the above errors will eliminate the crash that we are getting.

alfkil (89.150.118.165) @ 12 Dec 2012, 06:44.24

Wed, 12 Dec 2012 18:44:24 +0100

By: alfkil (89.150.118.165)

@xenic 
Well, obviously everything works perfectly well here. Are you interested in getting a debugging version of it to test what is wrong? And by the way: Which os version and filesystem are you using? 
@kas1e 
I think the problem is, that both db101 and LargeFile fails to find courier font (size 15) on your system. Do you have it installed?

xenic (71.58.155.85) @ 12 Dec 2012, 06:00.10

Wed, 12 Dec 2012 18:00:10 +0100

By: xenic (71.58.155.85)

Version 0.1 opens a window but when I select the "Open" gadget the program attempts to use "qt:src/gui" as the opening directory for the ASL requester which produces ascreen flash. If there is a default opening directory it should be one that's guaranteed to exist like RAM: or SYS: or PROGDIR:. The program crashes with a GR when I select a file and close the ASL requester. Even if I select "Kill" in GR my system freezes and I need a hard reboot. I don't think this program is ready for public release.

kas1e (78.36.143.146) @ 12 Dec 2012, 04:07.33

Wed, 12 Dec 2012 16:07:33 +0100

By: kas1e (78.36.143.146)

Tryed 0.1 version, and if i run it from the wb/icon or from shell, i all the time have a GR with crash in init(). Increasing of stack size not helps, but i can do "ignore DSIS" and editor runs.  Trying to open any file in it produce nothing as well (because of those DSI's imho).